Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore EHP heat index reference in link check #2528

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Ignore EHP heat index reference in link check #2528

merged 2 commits into from
Jun 10, 2022

Conversation

dcamron
Copy link
Member

@dcamron dcamron commented Jun 10, 2022

Updating the user agent didn't seem to help, so adding this to the ignore for now. Snuck in a few extra docstrings for good measure.

Checklist

@dcamron dcamron requested a review from a team as a code owner June 10, 2022 19:19
@dcamron dcamron requested review from dopplershift and removed request for a team June 10, 2022 19:19
@dcamron dcamron added Type: Maintenance Updates and clean ups (but not wrong) Area: Docs Affects documentation labels Jun 10, 2022
dopplershift
dopplershift approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments to clarify those too.

@dopplershift dopplershift enabled auto-merge June 10, 2022 19:24
@dopplershift dopplershift merged commit 0a8bcae into Unidata:main Jun 10, 2022
@github-actions github-actions bot added this to the May 2022 milestone Jun 10, 2022
@dopplershift dopplershift added the backport Pull Requests that are automatically back-ported to the stable release label Jul 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

🚨 Unable to cleanly backport this PR! 🚨

@dopplershift
Copy link
Member

Ah, we're off somewhere in the linkchecker config. Not a big deal since we're never running the full linkchecker on the stable branch anywhere.

@dopplershift dopplershift modified the milestones: May 2022, July 2022 Jul 1, 2022
@dopplershift dopplershift removed the backport Pull Requests that are automatically back-ported to the stable release label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Area: Docs Affects documentation Type: Maintenance Updates and clean ups (but not wrong)
Projects
Python
Status: Done
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Nightly build is failing
2 participants
@dcamron @dopplershift