-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make StationLookup a proper Mapping #2398
Conversation
@jthielen Do you think it would be enough to have a docstring example of use here? Of course, |
Yes and yes? Having |
This allows iteration, membership, etc. directly on the station information rather than needing to use the tables property.
0c43def
to
8711856
Compare
Ok, I added I'll leave a proper example to later, when I can come up with something useful--or if you get some cycles to breathe life into your idea @jthielen . |
8711856
to
00b2c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice and helpful! Small change for docs render. Also, question: are instances exported with the Exporter
context manager supposed to automatically end up with generated doc summaries? If so, I'm not seeing that here after a quick glance.
Includes a basic doctestable example.
00b2c89
to
acd0e61
Compare
|
I think I'm very okay skipping that and calling the explicit shoutout in the class docstring good enough! |
Description Of Changes
This allows iteration, membership, etc. directly on the station information rather than needing to use the
tables
property. The abstract base class gives us some things likeget()
,keys()
, andvalues()
for free.Checklist