Update coord criteria regex so that X prefixes or _ infixes don't break it #2347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Over the course of working on xarray-contrib/xwrf#14 and recieving feedback on it, bugs arose in some edge cases of the regex coordinate criteria, particularly,
XTIME
got interpretted as anx
axis coordinate (which is very much not right). To resolve this, I tightened the criteria with start and end matching, and then filled in what I'd otherwise expect to be allowed in between. WRF/xwrf-motivated test dimension names have also been added.Checklist
ClosesFully documented