Add unit-awareness to azimuth_range_to_lat_lon function #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
requested changes
Jul 22, 2021
src/metpy/calc/tools.py
Outdated
| @@ -887,6 +888,16 @@ def azimuth_range_to_lat_lon(azimuths, ranges, center_lon, center_lat, geod=None | |||
| else: | |||
| g = geod | |||
|
|
|||
| try: # convert range units to meters | |||
| ranges = ranges.to('meters').m | |||
There was a problem hiding this comment.
Been trying to use this more:
Suggested change
| ranges = ranges.to('meters').m | |
| ranges = ranges.m_as('meters') |
src/metpy/calc/tools.py
Outdated
| except AttributeError: # no units associated | ||
| warnings.warn('Range values are not a Pint-Quantity, assuming values are in meters.') | ||
| try: # convert azimuth units to degrees | ||
| azimuths = azimuths.to('degrees').m |
There was a problem hiding this comment.
Suggested change
| azimuths = azimuths.to('degrees').m | |
| azimuths = azimuths.m_as('degrees') |
dopplershift
added
Area: Calc
dopplershift
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR resolves #1970 by adding some unit handling and issue a warning if ranges and/or azimuths are supplied without units to alert the user to the assumed behavior. Test slightly updated to account for different use cases of units or no units attached to arrays.
Checklist