Copy method for declarative interface #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dopplershift
requested changes
May 25, 2021
dopplershift
added
Area: Plots
23ccozad
commented
May 25, 2021
23ccozad
force-pushed
the
copy_method_declarative_interface
branch
from
d4363d5 to
0eed012
Compare
MapPanel needed an explicity written __copy__() to make sure the copy process worked correctly. All other classes in declarative.py did not need it. A .copy() method is also provided for ease of use.
23ccozad
force-pushed
the
copy_method_declarative_interface
branch
from
0eed012 to
8d0b963
Compare
dopplershift
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adds a
.copy()method to just about every class indeclarative.py. This includesPlots2D(and hence all of its subclasses),MapPanel,PanelContainer, andPlotObs. The only class excluded isPanel, since it is currently empty.This
obj.copy()is equivalent to usingimport copyandcopy.copy(obj), except whenobjis a MapPanel.The
.copy()method for MapPanel required some additional changes in order to get it working. @dopplershift and I found that we needed to setallow_none=Truefor theparenttrait ofMapPanelin order to accommodate the process of copying a MapPanel that may not have been assigned a parent yet. A__copy__()method was written explicitly for MapPanel since a deeper copy of MapPanel'splotstrait is needed in order for the copy to work correctly.Test function
test_copy()was added intest_declarative.pyChecklist