fixes bug in issue 1758 #1876
Merged
fixes bug in issue 1758 #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
approved these changes
May 28, 2021
|
Will do. |
3 tasks
23ccozad
added a commit
to 23ccozad/MetPy
that referenced
this pull request
Jun 11, 2021
Updates parse_metar_to_dataframe() to return a dataframe with columns named current_wx1_symbol, current_wx2_symbol, and current_wx3_symbol, instead of current_weather, past_weather, and past_weather2
23ccozad
added a commit
to 23ccozad/MetPy
that referenced
this pull request
Jun 17, 2021
Updates parse_metar_to_dataframe() to return a dataframe with columns named current_wx1_symbol, current_wx2_symbol, and current_wx3_symbol, instead of current_weather, past_weather, and past_weather2
23ccozad
added a commit
to 23ccozad/MetPy
that referenced
this pull request
Jun 17, 2021
Updates parse_metar_to_dataframe() to return a dataframe with columns named current_wx1_symbol, current_wx2_symbol, and current_wx3_symbol, instead of current_weather, past_weather, and past_weather2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR is set to address issue #1758 where we do already distribute the weather codes via the metar_parse_file function. This issue is a bug that resides between the documentation, which states a different name, and the variable name generated in the function. This PR chooses to go with the naming convention of the documentation, which is more appropriate for what the those values actually are. In METAR, there is not a present and past configuration to the weather being reported. It is all current wx as there can be multiple phenomenon happening at one time.
There would still need to be some work on the documentation end for how the notes of the function display on the MetPy webpage. The current format is nearly unreadable.
https://unidata.github.io/MetPy/latest/api/generated/metpy.io.parse_metar_file.html#metpy.io.parse_metar_file
Checklist