Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR is a fix to the bug reported in issue #1635. The issue revolved around the use of a temperature variable in generating a weighted mean value. The fact that the
np.trapz
function now accepts unit arrays this fix simply allows the units to pass through the function and yield proper units at the end instead of stripping and reapplying units.A test has been added to account for using temperatures to compute a mean weighted value. The input is in Celsius with the output in Kelvin.
The only question, which I raised in a comment on the issue, is whether we desire to have the output come back this way, or force it back to the input units. The current behavior in this PR is similar to that of the
parcel_profile
function.Checklist