Fixes and improvements for wet_bulb_temperature #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1332) Turns out that moist_lapse did not cope with being given a uniform array of pressures (which while not useful, should just return an array full of the original temperature). This caused the wet_bulb_temperature calculation to fail when conditions were saturated. Simplify by using the support for passing a reference level explicitly to moist_lapse, and only request the value for our desired pressure.
Take advantage of the fact that lcl supports operating on entire grids to move it out of the loop. This shaves down the runtime for an average profiles (~120 levels) by about 10%.
dopplershift
added
Area: Calc
dcamron
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This fixes
wet_bulb_temperatureto no longer error out on saturated conditions. This was caused by some corner cases in moist_lapse (not handling inputs of uniform pressures due to strict > and < checks). The best fix is to use the fact thatmoist_lapse(now) supports passing in explicitly the starting pressure, separate from the desired pressure(s). Also fixmoist_lapseto work with all scalars.While here, refactor
wet_bulb_temperaturefor performance. Use the fact thatlclworks on grids to pull that calculation out of the loop. Improves performance by ~10% for a profile with 120 levels.Checklist