Fix build #1352
Merged
Fix build #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This apparently will be the default and the option is going away (in favor of opting-in to capture the output). Removing it silences a warning.
dopplershift
added
Area: Tests
|
There's a ton of crap (warnings, out of date configs) that needs updating, but I'll get that later. I just want to see CI finally green, and we can pull this into the 0.12.x branch. |
One has minor pixel-level differences, the other looks like fallout from matplotlib fixing some text positioning and clipping issues.
This test was created before aspect ratio work, but merged after. We use aspect ratio='auto' to keep the images the same across matplotlib versions, but this test was missing it. It didn't matter until matplotlib 3.2 came out.
drop_vars is only available on xarray 0.14.0
Have to see what's going on later.
Update image to reflect matplotlib 3.2, and skip on all prior versions.
Not sure where this was used exactly, but this does not seem to be used anywhere now.
|
Just a small error in accessing the xarray site when CI was running. Should be good to go. Yay for maintenance work! Ugh. |
|
No worries @jthielen. Something like that always creeps in while CI if failing for “known reasons”. |
dcamron
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Trying to get CI passing again. Mainly changes to fix tests with matplotlib 3.2 now that we have proper testing packages for it.
Checklist