Add station plot locations #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Plots
kgoebber
force-pushed
the
add_station_plot_locations
branch
from
92cd4db to
b6214da
Compare
dopplershift
previously approved these changes
Jan 12, 2020
dopplershift
force-pushed
the
add_station_plot_locations
branch
from
b6214da to
7d88355
Compare
dopplershift
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR adds a set of locations in the next ring around the station plot. This is to enable adding simple parameters/text/symbols around the station model with a named location call. I'm not excited by the 'N2', 'S2', 'E2', and 'W2', but I couldn't come up with something better at this point. The only other thought I had was to do 'NN', 'SS', 'EE', 'WW' for those second level directions. The other added locations work well into a common direction indicator 'NNW', 'SSE', etc.
Even though a tuple could be put through (and still can) it will be nicer to have this ability to use string names to plot additional things around the station model. For reference, GEMPAK had 25 locations (which had to be put in a particular order), this would bring our named locations up to a total of 21.
Checklist