Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for pre-releases #1242

Merged
merged 7 commits into from
Nov 29, 2019
Merged

Fixes for pre-releases #1242

merged 7 commits into from
Nov 29, 2019

Conversation

dopplershift
Copy link
Member

@dopplershift dopplershift commented Nov 28, 2019

Description Of Changes

Fixes to tests due to changes in:

  • SciPy 1.4.0rc1
  • Matplotlib 3.2.0rc2

Also fixes Travis to use local checkout of test data rather than fetching it all again.

Checklist

@dopplershift dopplershift added Area: Tests Affects tests Type: Maintenance Updates and clean ups (but not wrong) labels Nov 28, 2019
@dopplershift dopplershift added this to the 0.12 milestone Nov 28, 2019
The cached radius information isn't used anywhere in the algorithm, only
by some of the plotting dignostics. We can simplify things quite a bit
by only caching the circumcenters.
These were dependent on the exact indices of triangles being
returned--change to only be dependent on certain point indices and
centers.
This is to adjust for changes due to matplotlib 3.2
Need to properly set TEST_DATA_DIR on all test runs.
Coverage 4.3.4 on Python 3.8 produces some strange results that are
breaking CodeCov, so might as well update. Also, we're currently using
newer coverage on Windows anyways because it did not like the syntax we
were using to request an old one anyways--and codecov does not appear to
have a problem with it.
@dopplershift dopplershift merged commit 6be42bb into Unidata:master Nov 29, 2019
@dopplershift dopplershift deleted the fix-pre branch November 29, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tests Affects tests Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing with matplotlib 3.2.0rc1
1 participant