Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example to PW docstring #1227

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Add example to PW docstring #1227

merged 1 commit into from
Nov 5, 2019

Conversation

zbruick
Copy link
Contributor

@zbruick zbruick commented Nov 4, 2019

Description Of Changes

Adds an example to the PW doctoring on usage to clarify that an array of points is needed to calculate PW, due to the fact that it's derived via integration.

Checklist

@zbruick zbruick added Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality Area: Calc Pertains to calculations labels Nov 4, 2019
@zbruick zbruick added this to the 0.12 milestone Nov 4, 2019
@zbruick zbruick requested a review from dopplershift as a code owner November 4, 2019 16:08
Examples
--------
>>> pressure = np.array([1000, 950, 900]) * units.hPa
>>> dewpoint = np.array([20,15,10]) * units.degC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we’re not flake8-ing the docstrings. Pedantic, but should be spaces after the commas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - I agree that it helps with reading comprehension.

@dopplershift dopplershift merged commit c77e05d into Unidata:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert pressure for precipitable_water
2 participants