Update xarray time derivative for subsecond precision #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbruick
added
Area: Xarray
|
Python 2 was just dropped, so this can be rebased to get CI passing. Otherwise this looks good to me. |
|
Just rebased, but there were also some strange errors on AppVeyor with the time delta somehow returning negative? (see https://ci.appveyor.com/project/Unidata/metpy/builds/28338909/job/u4v2ik490pnbe0yx) I have no idea what is going wrong there. |
|
After finally getting my windows test env back up and working, I think the issue was |
zbruick
approved these changes
Oct 28, 2019
dopplershift
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In working with some high-temporal-resolution data with MetPy and xarray, I realized that the xarray time derivative only allows precision to the nearest second, since I had implemented it via conversion to a Unix timestamp in #899. Oops!
This PR modifies this to use
np.timedelta64[us]to permit microsecond precision instead, which should be fine enough for any meteorological application I can think of, but also coarse enough to fit climatological timescales in 64 bits (if I'm interpreting https://docs.scipy.org/doc/numpy/reference/arrays.datetime.html#datetime-units correctly).Since
DataArray.metpy.as_timestamp()was previously documented in the public API in #1175, I also deprecated it instead of removing it in favor ofDataArray.metpy.time_deltas.Also, should this be a property or method on the accessor?
Checklist