-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LFC problem and set CIN to 0 if positive #1202
Conversation
91f2f79
to
8faecbf
Compare
Based on the decision in #1190 (comment), would you be able add a citation to the USAF definition of LFC used by MetPy and an brief explanation of why the LFC cannot be below the LCL to the docstring, since that may or may not be what users would initially expect? |
Yup, can do. Thanks for the suggestion. Hopefully this resolves this once and for all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. Let's include a copy of the manual in docs/_static
and avoid linking to a horrifically slow site. I have a clean copy of the manual in my archives...
Here's the clean copy: aws-tr-79-006.pdf.gz |
e93d04a
to
1a68bad
Compare
Glad we had a better way to do it rather than ignoring the link, as it was failing at a rather historic rate. |
1a68bad
to
2079779
Compare
Description Of Changes
This fixes two problems - one with the LFC checking to make sure it and an EL both don't occur below a LCL - and the other where CIN was returned as a positive value when the parcel is absolutely unstable. CIN will be set to 0 in these cases, per conversation in #1190.
Checklist