Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LFC problem and set CIN to 0 if positive #1202

Merged
merged 4 commits into from
Oct 11, 2019

Conversation

zbruick
Copy link
Contributor

@zbruick zbruick commented Oct 9, 2019

Description Of Changes

This fixes two problems - one with the LFC checking to make sure it and an EL both don't occur below a LCL - and the other where CIN was returned as a positive value when the parcel is absolutely unstable. CIN will be set to 0 in these cases, per conversation in #1190.

Checklist

@zbruick zbruick added Type: Bug Something is not working like it should Area: Calc Pertains to calculations labels Oct 9, 2019
@zbruick zbruick added this to the 0.12 milestone Oct 9, 2019
@zbruick zbruick requested a review from dopplershift as a code owner October 9, 2019 20:09
@dopplershift dopplershift modified the milestones: 0.12, 0.11.1 Oct 9, 2019
@jthielen
Copy link
Collaborator

jthielen commented Oct 9, 2019

Based on the decision in #1190 (comment), would you be able add a citation to the USAF definition of LFC used by MetPy and an brief explanation of why the LFC cannot be below the LCL to the docstring, since that may or may not be what users would initially expect?

@zbruick
Copy link
Contributor Author

zbruick commented Oct 9, 2019

Yup, can do. Thanks for the suggestion. Hopefully this resolves this once and for all.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Let's include a copy of the manual in docs/_static and avoid linking to a horrifically slow site. I have a clean copy of the manual in my archives...

@dopplershift
Copy link
Member

Here's the clean copy: aws-tr-79-006.pdf.gz

@zbruick
Copy link
Contributor Author

zbruick commented Oct 11, 2019

Glad we had a better way to do it rather than ignoring the link, as it was failing at a rather historic rate.

@dopplershift dopplershift merged commit a928abf into Unidata:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cape_cin ValueError: zero-size array to reduction operation minimum which has no identity
3 participants