fix divergence unit requirement #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgoebber
force-pushed
the
fix_divergence
branch
from
75f0255 to
a744f71
Compare
|
Would it also make sense to update the docstring to not just refer to wind? |
zbruick
added
Area: Calc
kgoebber
force-pushed
the
fix_divergence
branch
from
a744f71 to
e3a1b9b
Compare
kgoebber
force-pushed
the
fix_divergence
branch
from
e3a1b9b to
5ff8700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This change removes the requirement that divergence must take wind speed. There are other variables that the divergence of a vector can be taken, which is not wind components. The prime example is Q-vectors.
Checklist