Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Change wheel directory on Travis #1191

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

dopplershift
Copy link
Member

This should keep the wheels from getting deleted when Travis cleans up
for deploying releases. Deleting them otherwise causes them to be
"re-downloaded" when building the final wheels, resulting in mass
upload to S3 on release.

@dopplershift dopplershift requested a review from zbruick as a code owner October 2, 2019 22:08
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should labels Oct 2, 2019
@dopplershift dopplershift added this to the 0.12 milestone Oct 2, 2019
Copy link
Contributor

@zbruick zbruick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be good once WHEELDIR is the correct path

.travis.yml Show resolved Hide resolved
This should keep the wheels from getting deleted when Travis cleans up
for deploying releases. Deleting them otherwise causes them to be
"re-downloaded" when building the final wheels, resulting in mass
upload to S3 on release.
@dopplershift
Copy link
Member Author

Code cov is having issues, and AppVeyor passed before I restarted (to try to fix code cov)—So I’m just going to merge since Travis looks just fine.

@dopplershift dopplershift merged commit adef621 into Unidata:master Oct 3, 2019
@dopplershift dopplershift deleted the travis-s3 branch October 3, 2019 17:25
@dopplershift dopplershift modified the milestones: 0.12, 0.11.1 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants