Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing import + "WP_error" #1

Closed
szepeviktor opened this issue Sep 30, 2020 · 3 comments
Closed

Missing import + "WP_error" #1

szepeviktor opened this issue Sep 30, 2020 · 3 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Sep 30, 2020 •
edited
Loading

Many abstracts have WP_error - note the "e" - and lack use WP_Error;
@alexstandiford
Copy link
Collaborator

Good catch - thank you!

@szepeviktor
Copy link
Contributor Author

Please consider using PHPStan.

alexstandiford added a commit that referenced this issue Jun 22, 2021
@alexstandiford
Fixes incorrect references to "WP_error" #1
ada477a
@alexstandiford alexstandiford mentioned this issue Jun 22, 2021
Merged
alexstandiford added a commit that referenced this issue Jun 22, 2021
@alexstandiford
Fixes incorrect references to "WP_error" #1 (#29)
5a01d08
@alexstandiford
Copy link
Collaborator

Resolved in #29

@szepeviktor szepeviktor mentioned this issue Jun 22, 2021
Closed
@alexstandiford alexstandiford mentioned this issue Jun 22, 2021
Merged
alexstandiford added a commit that referenced this issue Jun 22, 2021
@alexstandiford
Release/1.3.0 (#34)
6689264 
* Fixes incorrect references to "WP_error" #1 (#29)

* Introduces find method in Loader Registry. #28 (#30)

Resolves #28

* Issue/31 - Introduce middleware API (#33)

* Moves has_trait method in Underpin class. #31

This helper method is something that can be used outside of this system. With the trend of adding methods to Underpin as static methods, it makes sense to move this method, as well.

* Introduces Middleware API. #31

* Updates Readme #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @alexstandiford