Add Newtonsoft.Json to the list of assemblies available in CLI scripts #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miepee
approved these changes
Mar 30, 2024
|
Ideally would be nice to use system.json in the future, but that would require first the GUI to not rely on it. |
BenjaminUrquhart
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scripts that use
Newtonsoft.Jsonfor parsing JSON files fail to execute when using UndertaleModCli. Unlike the GUI tool, the CLI does not add the assembly to the references available to scripts.This PR fixes that by adding said reference.
Caveats
Adds
Newtonsoft.Jsonas a dependency to the CLI.