Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed functions duplications #1351

Merged
merged 6 commits into from
Jun 3, 2023
Merged

Fixed functions duplications #1351

merged 6 commits into from
Jun 3, 2023

Conversation

zxopink
Copy link
Contributor

@zxopink zxopink commented Apr 24, 2023

(I hope)

Description

Wrapped the decompiler and disassembler loop over duplications in a try and catch

@kenan238
Copy link

Finally

@zxopink
Copy link
Contributor Author

zxopink commented Apr 25, 2023

This time for real.
Before resorting to create a new function definitions for an already existing functions (A duplicate) it will look through the Functions in Data and if found will use the found one, otherwise make a new one

zxopink added 2 commits April 26, 2023 21:05
@zxopink
Find if function exists before creating one again
1dbd9fb
@zxopink
Final fix
0c27c83 
Tool detects functions and doesn't duplicate existing ones
kenan238
kenan238 approved these changes Apr 28, 2023
View reviewed changes
Copy link

@kenan238 kenan238 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, it works fine

@Grossley Grossley merged commit 35eb010 into UnderminersTeam:master Jun 3, 2023
@Jacky720 Jacky720 mentioned this pull request Jul 7, 2023
Open
@VladiStep VladiStep mentioned this pull request Dec 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenan238 kenan238 kenan238 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zxopink @kenan238 @Grossley