Optional integration with the Toolbar mod #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates for 1.0
Fixed bug w/Distributed Warehouse
|
One thing I forgot to mention: blizzy's toolbar requires 24x24 icons or smaller, so scaled-down versions of the icons will need to be created. I can add those, but I'm not sure what your release process is, so I'm not sure where you'd want them in the repositories. |
|
Very nice - if you could just toss them in the same location as the stock ones that would be good and I can merge this in. |
|
I've added 24x24 versions of the icons next to the original icons. They're named with a "24" suffix, so they're easy to distinguish. |
BobPalmer
added a commit
that referenced
this pull request
Feb 5, 2016
Optional integration with the Toolbar mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added code to automatically make use of the Toolbar mod if it is available, and continue using the stock toolbar when the Toolbar mod isn't available. I put the toolbar wrapper in USITools and make use of it in both USI-LS and in MKS, so there will be 3 separate pull requests (one for each repository).
While I was at it I noticed MKS issue 533 and fixed it (the toolbar button would just keep opening new windows instead of opening/closing the same window). This fix applies to both the stock toolbar and the Toolbar mod.