Add toggle topbar feature, and add UnstableApi annotation for experimental code #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggle button for toggle topbar in setting screen
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/src/main/java/com/techlads/composetv/features/home/leftmenu/data/MenuData.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/techlads/composetv/features/home/navigation/topbar/HomeTopBar.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/techlads/composetv/features/home/navigation/topbar/HomeTopBar.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/techlads/composetv/features/home/navigation/topbar/HomeTopBar.kt
Outdated
Show resolved
Hide resolved
UmairKhalid786
requested changes
Oct 22, 2023
There was a problem hiding this comment.
Good work @SeptAlfauzan, I really liked the way you quickly understood the project and delivered it quickly.
I have few requests
- Say no to hard code colors, rather use Theme colors, you can see some existing code example
- No return statement in composable, there are some places where I have added, I will also remove it
- Menu items
UmairKhalid786
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now the data to check if using the topbar still uses the StateFlow on the HomeViewModel class.