Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Japanese localization #960

Closed
wants to merge 1 commit into from
Closed

Conversation

h1data
Copy link
Contributor

@h1data h1data commented Aug 4, 2024

Improving Japanese localization for Cura issue#19438

Compiled uranium.po to mo file and checked the view of the application.

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Aug 4, 2024
@h1data
Copy link
Contributor Author

h1data commented Aug 4, 2024

After opening this PR, I've got notification about unit test was failed.
What should I do?
image

@wawanbreton
Copy link
Contributor

I have manually merged this branch to #972, @h1data please check that I didn't do any mistake, I had some conflicts but I think it is fine.

@h1data
Copy link
Contributor Author

h1data commented Oct 15, 2024

@wawanbreton Thanks, I checked po file in lokalise-2024-10-14_09-02-46 branch
and all changes are included, so it's OK!

@wawanbreton
Copy link
Contributor

Great, thanks for the feedback 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants