Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when starting Cura. #349

Closed
wants to merge 1 commit into from
Closed

Fix a crash when starting Cura. #349

wants to merge 1 commit into from

Conversation

krop
Copy link
Contributor

@krop krop commented May 15, 2018

If LIB_SUFFIX is used when invoking CMake, we have to let Cura know where the
plugins can be found.

Fixes #347

@thopiekar
Copy link
Contributor

Good work. There are only two things I would improve.

  1. Add a fallback for the case someone runs Cura (uranium incl.) from source. In that situation there won't be a LibDir.py.
    So a try on the import would be nice.

  2. Use as a file extension .py.in instead of .cmake. To be correct it is not a CMake file, but a .py which needs to be generated (.in).

@krop
Copy link
Contributor Author

krop commented May 16, 2018

Your #2. is a matter of taste (we use foo.cmake for KDE projects to indicate it's a file CMake has to parse), but ok.
edit
Working on your #1, then I'll prepare the next PR to make cura packager-friendly (ie: use CMake as it should be)

@thopiekar
Copy link
Contributor

Num 2 is based on how CuraVersion.py ist generated in Cura. Debian packagers are also adding this suffix often.
Also adding .py as prefix of the suffix makes it easier to understand that Python syntax is expected inside this file.

Num 1 is also implemented around CuraVersion.py. Since these projects are written in Python, most people like to skip the building part. So when someone is developing, then he can set the different PYTHONPATHs (incl build arcus and the engine) and she/he can start testing her/his changes directly.

If LIB_SUFFIX is used when invoking CMake, we have to let Cura know where the
plugins can be found.

Fixes #347
@krop
Copy link
Contributor Author

krop commented May 16, 2018

new PR incoming.

@krop krop closed this May 16, 2018
@Ghostkeeper
Copy link
Collaborator

Ghostkeeper commented Jun 15, 2018

Did you get around to making a new PR? I see what the problem is but it's hard to debug without setting up a whole VM with an installation that disambiguates between lib32 and lib64...

@krop
Copy link
Contributor Author

krop commented Jun 15, 2018

Yes, @LipuFei merged it already (#350)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants