Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra travel move to outer wall start position #2075

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

saumyaj3
Copy link
Contributor

@saumyaj3 saumyaj3 commented Apr 29, 2024

Associated Cura PR Ultimaker/Cura#18988
Contributes to CURA-11830

@saumyaj3 saumyaj3 marked this pull request as draft April 29, 2024 08:27
saumyaj3 and others added 3 commits May 1, 2024 17:20
Implemented a new method, addFirstWallTravel, to optimize initial wall travel. Added a property in the InsetOrderOptimizer constructor to distinguish between inside and outside walls, enhancing precision in function calls. Overall, these changes contribute to improved travel and wall printing in the GCode writer.

Related ticket: CURA-11830
@saumyaj3 saumyaj3 marked this pull request as ready for review May 2, 2024 11:17
@saumyaj3 saumyaj3 marked this pull request as draft May 2, 2024 11:18
saumyaj3 and others added 9 commits May 2, 2024 15:33
remove incorrect comma
The code changes refactor the addFirstWallTravel function in LayerPlan and implement a new feature where a special travel path to the start of a seam is implemented to start printing seamlessly. This involves optimizations in retraction, travel speed, and starting point for extrusion.

CURA-11830
Use standard methods, remove empty lines, and make sure the generation
and handling of the approach move is very similar to other travels
moves.

CURA-11830
Base automatically changed from CURA-9830_consolidate_polygon_classes to main May 17, 2024 08:43
We now split the approach path in two sub-paths, depending on whether we
have enough time to completely retract during the approach.
Also reworked some GCode generation functions to make them more clear
and more reusable.

CURA-11830
This makes more sense because you can't loop over an open polyline.
@wawanbreton
Copy link
Contributor

Would probably fix #1712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants