-
-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra travel move to outer wall start position #2075
Draft
saumyaj3
wants to merge
24
commits into
main
Choose a base branch
from
CURA-11830_smart_seam_unretract
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a new method, addFirstWallTravel, to optimize initial wall travel. Added a property in the InsetOrderOptimizer constructor to distinguish between inside and outside walls, enhancing precision in function calls. Overall, these changes contribute to improved travel and wall printing in the GCode writer. Related ticket: CURA-11830
…smart_seam_unretract
…smart_seam_unretract
…smart_seam_unretract
remove incorrect comma
…smart_seam_unretract
The code changes refactor the addFirstWallTravel function in LayerPlan and implement a new feature where a special travel path to the start of a seam is implemented to start printing seamlessly. This involves optimizations in retraction, travel speed, and starting point for extrusion. CURA-11830
Use standard methods, remove empty lines, and make sure the generation and handling of the approach move is very similar to other travels moves. CURA-11830
We now split the approach path in two sub-paths, depending on whether we have enough time to completely retract during the approach. Also reworked some GCode generation functions to make them more clear and more reusable. CURA-11830
This makes more sense because you can't loop over an open polyline.
Would probably fix #1712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Cura PR Ultimaker/Cura#18988
Contributes to CURA-11830