Implement syncing feature for Ultimaker account #18745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated account syncing functionality for logged-in and non-logged-in sessions in Ultimaker. More specifically, syncing is now engaged when the UI becomes visible and stopped when adding a machine action is triggered. The modifications also include fallback to login if the user is not logged in. CURA-11465
casperlamboo
approved these changes
Mar 29, 2024
HellAholic
deleted the
CURA-11465-addprinter-window-jumps-to-cloud-printer
branch
fieldOfView
reviewed
Mar 29, 2024
| @@ -133,7 +133,7 @@ Control | |||
| text = catalog.i18nc("@button", "Waiting for new printers") | |||
| busy = true; | |||
| enabled = false; | |||
| Cura.API.account.login(); | |||
| Cura.API.account.isLoggedIn? Cura.API.account.sync():Cura.API.account.login(); | |||
There was a problem hiding this comment.
Wouldn't an if/else statement have been much more readable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-11465
Description
Updated account syncing functionality for logged-in and non-logged-in sessions in Ultimaker. More specifically, syncing is now engaged when the UI becomes visible and stopped when adding a machine action-> addmachinedialog is triggered. The modifications also include fallback to login if the user is not logged in.