Validation hooks fixes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope this is merged soon! |
|
Hey @trevorloflin, thank you for your contribution! It will take me some time to review and test the code, as this is one of the most complex parts of the component. I really appreciate your work on this one! |
masiulis
approved these changes
Oct 20, 2023
masiulis
added a commit
that referenced
this pull request
Nov 3, 2023
Test #197 - validation step hooks
|
Released in 4.3.0, thanks @trevorloflin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two issues:
It restricts rowHook to run only on changed rows when called by the rows changed event (it should still run on all rows initially). It also turns rowHook and tableHook into (optionally) async functions. The relevant tests have also been updated to accept asynchronous functionality.