Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication implementation method #16

Open
sounak07 opened this issue Apr 21, 2018 · 16 comments
Open

Authentication implementation method #16

sounak07 opened this issue Apr 21, 2018 · 16 comments

Comments

@sounak07
Copy link

I would like to know how are we planning to implement auth. We can use jwt to implement login system along with social logins. Would like to know what moderators think about this?

@varunzxzx
Copy link
Collaborator

@sounak07 Yeah we can for token-based authentication. But, how you have planned to implement social logins when using jwt?

@sounak07
Copy link
Author

Local logis can be done easily by jwt and for social login, we can use this strategy

0_wtdhgaga8n661dfl_

We need passport for this.

@specbug
Copy link
Collaborator

specbug commented Apr 22, 2018

passport.js provides dependencies for social login using jwt. @sounak07 is right it can be done with passport.

@varunzxzx
Copy link
Collaborator

I am concerned about the security of the app if we use token-based authentication, then how we will maintain sessions. If the answer is storing the token in the local storage, then the token can be comprised very easily. What is your opinion on this?

@sounak07
Copy link
Author

If u are concerned about XSS, Xss happen when we allow users to input malicious code to our application. We can sanitize all data before letting user interact with our database. I would say let's start with local storage may later we can implement more secure techniques if needed. Please let me know your thoughts @varunzxzx

@varunzxzx
Copy link
Collaborator

@sounak07 Yeah we can sanitize the input. Angular does it automatically but we have to figure it for react(maybe some libraries are already available). As you suggested, let's begin with the local storage we will adopt some more secure way till we reach the production stage. But first, we've to finalise the models at least the User model so that you can begin setting things up.

@specbug
Copy link
Collaborator

specbug commented Apr 22, 2018

React already encodes all untrusted cross site references (upto some extent) and using something like cookies also comes with its downfall. So i think it's better to just stick with localStorage and maybe encrypt the data for now.

@sounak07
Copy link
Author

Please let me know once the model is finalized, I would like to work on this. @varunzxzx

@saini-himanshu
Copy link

saini-himanshu commented Apr 22, 2018

what about Google Auth api , is it possible to implement Authentication with it in this.

@Sahil-Dhawan
Copy link

I guess google auth would be better , we could actually provide users an option between platforms like google and facebook

@ghost
Copy link

ghost commented May 3, 2018

Does anyone work on authentication part. I can contribute

@sounak07
Copy link
Author

sounak07 commented May 3, 2018

Is the user model decided yet @varunzxzx so that we can work on auth??

@Abdulkadir98
Copy link
Contributor

Abdulkadir98 commented May 3, 2018 via email

@varunzxzx
Copy link
Collaborator

@Abdulkadir98 Can you describe the issue in our slack channel?

@varunzxzx
Copy link
Collaborator

@sounak07 User model has been added.

@sounak07
Copy link
Author

sounak07 commented May 5, 2018

Ok I will start the auth part then @varunzxzx .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants