Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill syncing #82

Merged
merged 17 commits into from
Oct 7, 2020
Merged

Skill syncing #82

merged 17 commits into from
Oct 7, 2020

Conversation

MickVermeulen
Copy link
Member

Refactor of the entire skill system. Skill trees are executed in two steps: first a (de-)serialization step and then and execute step. The (de-)serialization handles the reading or writing of the behavior GMs and prepares the tree to be executed using a set of execution parameters, EchoStartSkill and EchoSyncSkill are then sent immediately after (de-)serialization to allow very fast communication between client and server. Once the tree is ready to be executed it can be executed as a background process.

@MickVermeulen MickVermeulen requested review from Wincent01 and Jettford and removed request for Wincent01 October 7, 2020 10:05
@MickVermeulen MickVermeulen self-assigned this Oct 7, 2020
@MickVermeulen MickVermeulen linked an issue Oct 7, 2020 that may be closed by this pull request
@Wincent01
Copy link
Member

Does not have anything todo with the parameters.Context.ExplicitTarget, if UsePickedTarget is true and a target exists, it branches from there. The validity of a target is checked on sync.
https://github.com/yuwui/Uchu/blob/skill-syncing/Uchu.World/Systems/Behaviors/TacArcBehavior.cs#L45
https://github.com/yuwui/Uchu/blob/skill-syncing/Uchu.World/Systems/Behaviors/TacArcBehavior.cs#L166

@MickVermeulen MickVermeulen merged commit 6999bd7 into master Oct 7, 2020
@MickVermeulen MickVermeulen deleted the skill-syncing branch October 8, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skill syncing isn't up to date
2 participants