Improve the behavior of death planes

[Frozenreflex]

Fixes #190 and #74

[TheNexusAvenger]

Glad to see this is finally a thing considering how long many people have looked into this. Got a few comments.

[TheNexusAvenger]

Played around with this for a bit. For the non-properties, this is what I noticed:

• World 1000 (Venture Explorer) and part of World 1300 (Gnarled Forest): Works completely as expected.
  * Worlds 1100 (Avant Gardens), 1200 (Nimbus Station), 1604 (Portabello), and part of World 1300 (Gnarled Forest): Missing the script scripts\ai\AG\L_ACT_SHARK_PLAYER_DEATH_TRIGGER.lua. May be similar to the other script except for the achivements. (Edit: Didn't have that commit locally for some reason.)
• Worlds 1400 (Forbidden Valley) and 1800 (Crux Prime): Couldn't find a script, but Object 5652 appears relevant.
• World 2000 (Ninjago): Couldn't find a script, but Object 14510 appears relevant.

[Frozenreflex]

* Worlds 1100 (Avant Gardens), 1200 (Nimbus Station), 1604 (Portabello), and part of World 1300 (Gnarled Forest): Missing the script `scripts\ai\AG\L_ACT_SHARK_PLAYER_DEATH_TRIGGER.lua`. May be similar to the other script except for the achivements.

The directory in the comment in the code is wrong, it's actually the one you mentioned, but that script should still run normally since it only cares about the name of the lua file... does it not run at all?

[TheNexusAvenger]

The directory in the comment in the code is wrong, it's actually the one you mentioned, but that script should still run normally since it only cares about the name of the lua file... does it not run at all?

Uh, oops. I didn't have that commit when testing for some reason. That can be ignored.

[TheNexusAvenger]

Worlds 1400 (Forbidden Valley) and 1800 (Crux Prime): Couldn't find a script, but Object 5652 appears relevant.
World 2000 (Ninjago): Couldn't find a script, but Object 14510 appears relevant.

Did some more digging around. We currently check custom_script_server in LuaScriptComponent, but we don't check custom_script_client. If we add reading this and add the relevant script(s), this will either finish death planes for all non-properties, or everything if the teleport script is added for properties.

[TheNexusAvenger]

Additional changes that were made:

• Tweaked object script loading to reduce duplicate code. Check for custom_script_server for the falling player scripts.
• Add death planes for the remaining worlds.
• Add teleport scripts for properties.
• Fix player physics being too low, resulting in being killed on land in Portabello (1604).

Open problem:

• The falling death plane is hard-coded to use 2 seconds as a delay before smashing. May have missed something, but I couldn't figure out a better option. 2 seconds doesn't work as expected in all cases, mainly in some cases of Crux Prime (too long) and Ninjago (too short).
• The main Assembly teleporters in Nexus Tower no longer work because the physics object is underground.
  • Edit: Hacky workaround - In PrimitiveModelComponent, make the "Cylinder" (currently a sphere) of radius Math.Max(cylinderSize.X, cylinderSize.Y) instead of just cylinderSize.Y, which may be the smaller of the dimensions. Supporting proper Cylinder collisions is the better move though. No guarantee I will look at it.

[TheNexusAvenger]

Tested the functionality of this. There are 2 outstanding issues currently:

• The shark attack in Nimbus Station no longer works.
• The fall death in Crux Prime no longer works.

The death planes in all other worlds seem to work, and the main Assembly teleporters work again.

[TheNexusAvenger]

Changes for the death plane code looks good. Got 2 questions about 2 other changes.