Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implment sentry error logging for packets, gms and events #215

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

MickVermeulen
Copy link
Member

@MickVermeulen MickVermeulen commented Feb 22, 2021

Allows the user to specify a sentry DSN (see: https://sentry.io/) to which exception logging is sent. This does not affect performance as these requests are sent in the background. If no sentry DSN is provided calls to sentry logging are no-ops. I've been testing this on my test server over the last two days and has performed great.

Copy link
Member

@TheNexusAvenger TheNexusAvenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look mostly fine. Just a question about the usage without Sentry.

@TheNexusAvenger TheNexusAvenger merged commit 96a1233 into dev Feb 25, 2021
@TheNexusAvenger TheNexusAvenger deleted the enhancement/sentry-logging branch February 25, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants