Improve Forbidden Valley Load Times #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late response but would this improve load times for other worlds as well? |
|
Avant Gardens was loading a bit faster when I tried, but not by much. Maybe half a second or so. Forbidden Valley seemed to be the only world where the level parsing was the slowest part by a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load times for Forbidden Valley are currently several minutes, which is due to an IO bottleneck when parsing the .lvl files in InfectedRose. This pull request changes the file opening method to load the entire file into memory for parsing instead of relying on gradually reading the file. This change reduces the load times to <25 seconds on my system for Forbidden Valley.