Fix character name issues (creating and approving) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer possible to create multiple characters with the same name, /approve <name> now works, /approve all renamed to /approve *, /approve with extra space no longer sets someone's name to an empty string
|
Is this PR complete or work in progress? |
This was
linked to
issues
Nov 8, 2020
Jettford
approved these changes
Nov 8, 2020
MickVermeulen
approved these changes
Nov 8, 2020
|
Feel free to ping us in the Uchu dev discord along with the PR url btw :). All seems well, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127, #128 and #129
/approve <name>now works, no longer needs<name>as second argument/approve allrenamed to/approve *(to make it possible to approve the custom name "all")/approvewith extra space no longer sets someone's name to an empty string