-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stream=
kwarg to Recognizer.listen
#757
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indirection here is notably strange, so I thought I'd explain here:
In newer versions of python, if a method contains the
yield
keyword, it always returns a generator. As such, the original implementation (now in_listen
) always returns a generator, and this wrapper method either returns that generator without modification, or iterates on the generator and returns the only result.There's an alternate path here, where
_listen
always yields buffers, andlisten
is responsible for merging them into a single payload forstream=False
-- this would also mean moving the logic for truncating the final non-speech frames, which was slightly less preferable to me.In either case, users of
stream=True
are going to get a few extra frames of audio. Changing that behavior would require the delaying stream emission fornon_speaking_buffer_count
, and it's a bit of a toss-up as to which is the lower-latency end-to-end solution.