specify netcdf variable names in global parameter file #379
Conversation
|
This is ready for a review from @bartnijssen or @tbohn, although it may be easier to wait until after #378 is merged. |
|
@wietsefranssen - I reworked your |
| @@ -41,7 +41,6 @@ double calc_netshort(double, int, double, double *); | |||
| void check_files(filep_struct *, filenames_struct *); | |||
| FILE *check_state_file(char *, size_t, size_t, int *); | |||
| void close_files(filep_struct *, out_data_file_struct *, filenames_struct *); | |||
| size_t count_force_vars(FILE *gp); | |||
There was a problem hiding this comment.
Why is this not needed for classic? Wasn't this just introduced? Does that mean that in vic_classic the user still needs to specify the number of forcing variables?
There was a problem hiding this comment.
This was just moved to driver/shared
|
May be worth a second look or a bit of discussion about the comments above. |
|
I've address all of @bartnijssen's original comments. As I mentioned before, changing the names of @wietsefranssen - I'd still appreciate you looking over this if you can get a chance. This needs a rebase/squash then it should be ready to merge (pending no further comments). |
|
I've looked at all @bartnijssen's comments and I agree with all of them. I also agree in changing the radiations names (and on to choose from different options). This avoids confusion. good work! |
specify netcdf variable names in global parameter file
This PR closes #211. Forcing variables can be specified in the global parameter following the convention proposed in #211.
blocked by #378