Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logging #170

Closed
wants to merge 4 commits into from
Closed

Feature/logging #170

wants to merge 4 commits into from

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Dec 5, 2014

addresses #64.

Further cleanup of existing print statements is necessary to make use of this new functionality but it is there now.

@bartnijssen
Copy link
Member

Build fails - not merged

@bartnijssen bartnijssen closed this Dec 5, 2014
@jhamman jhamman reopened this Dec 5, 2014
@jhamman
Copy link
Member Author

jhamman commented Dec 5, 2014

We don't need to close the PR. I have another commit on the way.

@bartnijssen
Copy link
Member

You can always reopen it like you did here. I don't want open-ended pull requests that don't compile. Just get the whole request ready and submit or I'll keep closing em as fast as the come in ;)

@bartnijssen bartnijssen closed this Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants