bug report: error in vegetation parameter(LAI, albedo, etc) initialization when VEGPARAM_LAI=FALSE

[pengbinpeluo]

Hi Joe,
I'm afraid that I have found another bug in the released version 4.2.c. When "options.VEGPARAM_LAI" is FALSE, the model will give biased albedo output since the vegetation albedo is not initialized in read_vegparam.c. To fix this bug, the following lines in read_vegparam.c should be moved out of the "if ( options.VEGPARAM_LAI )":

  for ( j = 0; j < MONTHSPERYEAR; j++ ) {
    temp[i].albedo[j] = veg_lib[temp[i].veg_class].albedo[j];
    temp[i].LAI[j] = veg_lib[temp[i].veg_class].LAI[j];
    temp[i].vegcover[j] = veg_lib[temp[i].veg_class].vegcover[j];
    temp[i].Wdmax[j] = veg_lib[temp[i].veg_class].Wdmax[j];
  }

Regards,
Bin Peng(112233pengbin@163.com or pengbin@radi.ac.cn)

[jhamman]

Thanks for the report. I'm cc'ing @tbohn since he knows this section of the code best.

@pengbinpeluo - would you be willing to submit a bug fix pull request for this?

[tbohn]

Yes, I see what @pengbinpeluo is referring to. I think the fix should be: move lines 242-247 to immediately before line 217.

[pengbinpeluo]

Hi Joe and Ted, I have submitted a bug fix pull request for this issue. Cheers!