Support get ith element location in a region for mixed data types. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasiddique
reviewed
Jul 29, 2024
Comment on lines
+503
to
+504
| auto locSrc = srcRegion.locateIthElemInRegion(j); | ||
| auto locDest = destRegion.locateIthElemInRegion(j); |
There was a problem hiding this comment.
how are you deciding if it's vertical or horizontal? as it seems like previously we were passing it on a parameter.
There was a problem hiding this comment.
The key is numColsPerElement. For vertical layout it's 1. Each region knows if it's V or H layout.
fasiddique
reviewed
Jul 29, 2024
Comment on lines
+51
to
+53
| assert(i < getNumElemInRegion()); | ||
| unsigned rowIdx = m_rowIdx; // only one row of elements per region | ||
| unsigned colIdx = m_colIdx + i * m_numColsPerElem; |
There was a problem hiding this comment.
for vertical layout isn't it multiple rows?
There was a problem hiding this comment.
Each region contains one row of elements, no matter if it's V or H layout. You can think each element takes a rectangle area of bits, and here we need to get the location of upper left corner.
fasiddique
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd batch of code for supporting mixed data types and element padding:
No impact on existing behavior. Can be merged before other PRs.
Related to Issue #16.