Minor updates to support two region disaggregation #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/StateiorFunctions.R
Outdated
| @@ -12,14 +12,15 @@ | |||
| #' @return A list of two-region IO data of model iolevel and year. | |||
| getTwoRegionIOData <- function(model, dataname) { | |||
| # Define state, year and iolevel | |||
| alias <- ifelse(!is.na(model$specs$alias), model$specs$alias, NULL) | |||
There was a problem hiding this comment.
is an alias now part of a model specification file or was it added as a part of specs after reading in the spec file in and parsing it out of the model name?
There was a problem hiding this comment.
Yes as I was thinking about this, I think we have to have the alias as its own (optional) field in the model specs. We can't use the text parsing because older models don't fit the schema (and so grabbing the second to last substring between - or something would grab GHG for instance).
In Stateior, as a means to differentiate model build files, we are tagging them with the alias when they are built, e.g. TwoRegion_Summary_Use_{alias}.rds or whatever.
But I need to add to the model specs format specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with USEPA/stateior#46
Revises handling of two region data acquisition to incorporate alias instead of disaggregation name. Incorporates necessary input files to support two region disaggregations.
Resolves #290