Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistage dockerfiles #484

Merged
merged 16 commits into from
May 20, 2023
Merged

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented May 20, 2023

Description

This PR adds multistage / target docker files for the client and server.

So the Dockerfiles have a dev target and a production target. The client also has a test target but we did not include that for the server (unfortunately) b/c the test can't be filtered out in a build step like they can for the client and I would prefer not to increase our docker image size with those files. we don't talk about the test target in the docs. The docs have been updated with a Containerization section under the deployment chapter. Hope to include more in this section when we're looking at using our containers for deployment.

We also now only build 1 image for the server, celery worker, and celery scheduler for our docker compose local development. It does seem to speed things up a little bit, likely just from the fact that we've reduced the number of docker images the daemon has to build from 4 to 2, so just a little less stress on the local laptop.

We've also updated many of the dependencies to stay on top of vulnerabilities.

Issue ticket number and link

closes #329

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added server Related to backend workings (Django/Rest API) client Related to front end workings (React/Redux) labels May 20, 2023
@dpgraham4401 dpgraham4401 added the CI/CD Requires modiciations to the continuous integration pipeline(s) label May 20, 2023
@dpgraham4401 dpgraham4401 merged commit c12d794 into USEPA:main May 20, 2023
@dpgraham4401 dpgraham4401 deleted the multitarget_dockerfiles branch May 20, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Requires modiciations to the continuous integration pipeline(s) client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multistage (target) Dockerfiles
1 participant