-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multistage dockerfiles #484
Merged
dpgraham4401
merged 16 commits into
USEPA:main
from
dpgraham4401:multitarget_dockerfiles
May 20, 2023
Merged
Multistage dockerfiles #484
dpgraham4401
merged 16 commits into
USEPA:main
from
dpgraham4401:multitarget_dockerfiles
May 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e image 3 times just to run different commands)
…aming in Dockerfiles
github-actions
bot
added
server
Related to backend workings (Django/Rest API)
client
Related to front end workings (React/Redux)
labels
May 20, 2023
dpgraham4401
added
the
CI/CD
Requires modiciations to the continuous integration pipeline(s)
label
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multistage / target docker files for the client and server.
So the Dockerfiles have a
dev
target and aproduction
target. The client also has atest
target but we did not include that for the server (unfortunately) b/c the test can't be filtered out in a build step like they can for the client and I would prefer not to increase our docker image size with those files. we don't talk about thetest
target in the docs. The docs have been updated with a Containerization section under the deployment chapter. Hope to include more in this section when we're looking at using our containers for deployment.We also now only build 1 image for the server, celery worker, and celery scheduler for our docker compose local development. It does seem to speed things up a little bit, likely just from the fact that we've reduced the number of docker images the daemon has to build from 4 to 2, so just a little less stress on the local laptop.
We've also updated many of the dependencies to stay on top of vulnerabilities.
Issue ticket number and link
closes #329
Checklist