Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction info model #387 #477

Merged
merged 2 commits into from
May 12, 2023
Merged

Correction info model #387 #477

merged 2 commits into from
May 12, 2023

Conversation

tishiljk3
Copy link
Contributor

Description

Issue ticket number and link closes 387

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

tishiljk3 and others added 2 commits May 12, 2023 10:19
@tishiljk3
CorrectIionInfo Model USEPA#387
59a5371 
- Add correction info model
- Add correction info migration files
@rahulrameshan
Merge pull request #4 from tishiljk3/correction_info_model
17e50cd
@github-actions github-actions bot added database changes that require modification to the database schema server Related to backend workings (Django/Rest API) labels May 12, 2023
@dpgraham4401 dpgraham4401 self-requested a review May 12, 2023 12:57
dpgraham4401
dpgraham4401 approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@dpgraham4401 dpgraham4401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for the clean readable model that follows the schema

server/apps/trak/models/manifest_models.py Show resolved Hide resolved
@dpgraham4401 dpgraham4401 merged commit 4e76dd2 into USEPA:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgraham4401 dpgraham4401 dpgraham4401 approved these changes

Assignees
No one assigned
Labels
database changes that require modification to the database schema server Related to backend workings (Django/Rest API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CorrectionInfo model
3 participants
@tishiljk3 @dpgraham4401 @rahulrameshan