Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Info Serializer #384 #455

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Import Info Serializer #384 #455

merged 4 commits into from
Apr 28, 2023

Conversation

tishiljk3
Copy link
Contributor

Description

Serializer for ImportInfo

Issue ticket number and link

closes 384

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

tishiljk3 and others added 2 commits April 27, 2023 14:02
- Add ImportInfo  serializer
- Add Portofentry serializer
@github-actions github-actions bot added the server Related to backend workings (Django/Rest API) label Apr 27, 2023
Copy link
Member

@dpgraham4401 dpgraham4401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every looks great, one minor change to the capitalization of the port of entry field.

server/apps/trak/serializers/manifest_ser.py Outdated Show resolved Hide resolved
@dpgraham4401
Copy link
Member

@tishiljk3 @rahulrameshan just a tip (you can take it or leave it)

We prefer if our contributors create a git branch, make your edits in that new branch, push that branch to GitHub, and create the PR from that branch instead of the 'main'.

When creating the PR, we also prefer that the "Allow edits from maintainers" be checked (set to yes).

With this setup, if there's something small that needs to change before the PR can be merged, we can still merge the PR if the contributors don't have time to make the changes themselves.

I will update our contributors guide to include this info.

Cheers!

Copy link
Member

@dpgraham4401 dpgraham4401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @tishiljk3! stellar stuff as always.

@dpgraham4401 dpgraham4401 merged commit 9fd4874 into USEPA:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to backend workings (Django/Rest API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportInfo serializer
3 participants