Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearchitect client project structure #451

Merged

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Apr 20, 2023

Description

This PR addresses something I've been wanting to do for the client source for a while to help the project structure and cohesion between type/interface definitions and the components that use them.

The component modules have been rename/reorged so similar components are groups together. I also moved most of the the type definitions to the component module instead of just having them float out in a separate types module on their own for use by any component. This should make it a little easier to identify when a interface is being shared by too many things and may be violating the single responsibility principle (for example, the rcraSite schema is a suspect candidate).

So a lot of moving stuff around to where things should have been originally but nothing really changing.

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added server Related to backend workings (Django/Rest API) client Related to front end workings (React/Redux) test Unit tests are, or need to be, included labels Apr 20, 2023
@dpgraham4401 dpgraham4401 merged commit 29a451d into USEPA:main Apr 20, 2023
@dpgraham4401 dpgraham4401 deleted the rearchitect_client_project_structure branch April 20, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant