ManifestForm status validation/logic and SubmissionType logic #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns to ManifestForm. These fields are disabled past a certain status. initial default values for ManifestForm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some logic to the ManifestForm as to whether the fields can be edited. Now, once the manifest has reached a
Scheduledstatus neither of the fields can be edited. It also adds the rest of the remaining options to both of these select fields (as hidden choices which we use to display the current status and submission type but do not allow them to be edited once they reach the point in the shipment life cycle that they are managed by the EPA RCRAInfo system).This PR also re-adds a named volume back to the docker compose file.
This PR also adds initial default values for the
ManifestFormIssue ticket number and link
relevant to #443
closes #439
Checklist