Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportInfo adjustemnts #438

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

dpgraham4401
Copy link
Member

Description

This PR makes a few quick typo fixes and adjustments to the recent ImportInfo ORM model. Like many of the models, we do not store RcraInfo's Locality information directly, but just store the state/country/region then represent those resources in the same way as RcraInfo in our interfaces. To that end, we remove Locality model and replace with charfield with state choices in our PortOfEntry model.

Issue ticket number and link

No related ticket

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Other Stuff

@github-actions github-actions bot added database changes that require modification to the database schema server Related to backend workings (Django/Rest API) labels Apr 18, 2023
@github-actions github-actions bot added the CI/CD Requires modiciations to the continuous integration pipeline(s) label Apr 18, 2023
@dpgraham4401 dpgraham4401 merged commit 7e27fa5 into USEPA:main Apr 18, 2023
@dpgraham4401 dpgraham4401 deleted the ImportInfo_adjustments branch April 18, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Requires modiciations to the continuous integration pipeline(s) database changes that require modification to the database schema server Related to backend workings (Django/Rest API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant