Pull manifest iteration bug #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion docstring for existing_mtn, and allow passing Q objects in *args adjust parameters pull_manifest parameter typing to List[str], fix get_handler_query when transporter
github-actions
bot
added
server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an error when a string was passed to the
pull_manifestcelery task during theManifestService.sign_manifestmethod. It also fixes a Query object factory for when the front end submit aQuickerSignForm.It makes a few minor modifications to the docs, removes logging from the dependencies injected into the services.
Issue ticket number and link
Checklist
Other Stuff