Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta-cyfluthrin as target for cyfluthrin #165

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

fchichorro
Copy link
Contributor

Ecoinvent maps recipe cyfluthrin to beta-cyfluthrin. We could do the same, i.e., to use cyfluthrin as a proxy for beta-cyfluthrin? The advantage to that is that ecoinvent processes with beta-cyfluthrin get impacts for this elementary flow. I used the recipe cyfluthrin to fedefl cyfluthrin as a template to create the new flow mappings. @ErCollao @ganorris.

ecoinvent do that in their mapping
@bl-young
Copy link
Collaborator

Hi @fchichorro thanks for digging into all of these. One minor request: we try to maintain the flowables and contexts separately, so in most of the cases you've submitted, you can simply add one line to the flowables mapping file (e.g. ReCiPe2016FlowableMappings.csv), and then run the script build_lcia_mapping.py (note you'll need to change the target LCIA method in line 14).
This should update the mapping files exactly as you have already done, but it reduces the risk of typos and such.

This may not work for #164, which will require a different approach.

@fchichorro
Copy link
Contributor Author

Hi @bl-young, thank you for the feedback. I had indeed not noticed those functions, I will surely use them for any subsequent commit.

@bl-young bl-young changed the base branch from master to flow_updates August 29, 2023 02:19
@bl-young bl-young merged commit 9a0afc2 into USEPA:flow_updates Aug 29, 2023
@bl-young bl-young added this to the v1.2.5 milestone Dec 3, 2024
@bl-young bl-young mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants