-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have FVS return valid execution codes? #36
Comments
wagnerds
added a commit
that referenced
this issue
Mar 6, 2024
commit ff7c8a2 Author: lance-david <lance.david@usda.gov> Date: Fri Apr 14 08:51:16 2023 -0600 Initialization of variables in fmcfir.f Label change for AK variant elevation reporting 10's feet to 100's feet commit 3501d6e Merge: e6e741b a287651 Author: LANCE R. DAVID <lance.david@usda.gov> Date: Thu Mar 30 07:49:59 2023 -0600 Merge pull request #37 from forest-service/_pr28_Crookston Added testing of the fvs[Get|Set]SpeciesAttrs code. commit a287651 Author: Nicholas Crookston <ncrookston.fs@gmail.com> Date: Mon Mar 13 13:42:29 2023 -0700 Added testing of the fvs[Get|Set]SpeciesAttrs code. Fixed a bug in how stoppoint 7 works. Added more code to the test of the APIviaR that would have shown the error had the test been added prior to now. Updated the 'save' files to account for these changes. Added test for using fvsCutNow() option in rFVS and added code and tests that trap using the thinprsc keyword in a way that causes a conflict with the use of the rFVS fvsCutNow function. commit e6e741b Author: Daniel Wagner <daniel.s.wagner@usda.gov> Date: Sun Mar 12 15:51:31 2023 -0400 clean up of X1 variable from fvsvol.f commit 3cd3d05 Merge: 524cfb8 2b05de7 Author: LANCE R. DAVID <lance.david@usda.gov> Date: Fri Feb 24 13:30:57 2023 -0700 Merge pull request #36 from forest-service/Q2-2023-Ver-Numbering Updated to version and revision numbers for Q2 commit 2b05de7 Author: Daniel Wagner <daniel.s.wagner@usda.gov> Date: Fri Feb 24 15:26:42 2023 -0500 Updated to version and revision numbers for Q2 commit 524cfb8 Merge: 229d13f ffbaba3 Author: LANCE R. DAVID <lance.david@usda.gov> Date: Fri Feb 24 12:07:12 2023 -0700 Merge pull request #35 from forest-service/new-event-monitor-variables New event monitor variables commit ffbaba3 Merge: 124d8ec 229d13f Author: Daniel Wagner <daniel.s.wagner@usda.gov> Date: Fri Feb 24 10:16:21 2023 -0500 Merge branch 'development' of https://code.fs.usda.gov/forest-service/ForestVegetationSimulator into new-event-monitor-variables commit 124d8ec Merge: 5c02911 e373625 Author: Daniel Wagner <daniel.s.wagner@usda.gov> Date: Fri Feb 17 11:32:05 2023 -0500 Merge branch 'development' of https://code.fs.usda.gov/forest-service/ForestVegetationSimulator into new-event-monitor-variables commit 5c02911 Merge: 5668311 652f6a3 Author: Daniel Wagner <daniel.s.wagner@usda.gov> Date: Thu Feb 16 13:18:37 2023 -0500 Merge branch 'development' of https://code.fs.usda.gov/forest-service/ForestVegetationSimulator into new-event-monitor-variables commit 5668311 Author: Daniel Wagner <daniel.s.wagner@usda.gov> Date: Thu Feb 16 13:18:05 2023 -0500 Initial event monitor expansion code to include before and after stand height weighed by basal area. STILL NEEDS TO BE VERIFIED AND TESTED
Is "STOP 20" a valid run? I am getting that but not seeing any errors in the .out file. I'm still curious if you might consider switching to "industry standard" exit codes? |
Hello,
The FVS stop code is the highest error level encountered for the entire run which may have multiple stands. STOP 20 is most commonly a keyword error. It may be a keyword out of place and not within its necessary block like Database/End, ESTAB/End, Compute/End, a misspelled keyword or maybe a leading blank or could be an invalid parameter on a keyword. Whatever the case, you will find a error message in your main output file. The writing of that error is what sets the stop code for the run.
If you are using a current version of FVS, there will be a FVS_Error table in the output database holding all warnings and errors for the run.
It all depends on what keyword triggered that message and it may have also caused additional keywords to be ignored. I would consider a run with a Stop 20 to be invalid because at the very minimum, at least one parameter or action you intended to be included was not.
Hope this helps.
From: jgrn307 ***@***.***>
Sent: Thursday, November 14, 2024 2:53 PM
To: USDAForestService/ForestVegetationSimulator ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [USDAForestService/ForestVegetationSimulator] Have FVS return valid execution codes? (Issue #36)
Is "STOP 20" a valid run? I am getting that but not seeing any errors in the .out file. I'm still curious if you might consider switching to "industry standard" exit codes?
-
Reply to this email directly, view it on GitHub<#36 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZVWHW5NWYIGAK2KPWADEI32AULTDAVCNFSM6AAAAABRZ37JMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGQ4DANRQHA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.
|
tharen
pushed a commit
to forest-modeling/ForestVegetationSimulator
that referenced
this issue
Dec 12, 2024
…er-Numbering Updated to version and revision numbers for Q2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was hoping you would be willing to tweak FVS so if it runs properly, it returns a valid exit code (e.g. 0) or, if it has a problem, it returns some other code.
https://www.agileconnection.com/article/overview-linux-exit-codes
We're wrapping FVS in python and it doesn't behave in quite a "standard" way when facing errors. Thanks!
The text was updated successfully, but these errors were encountered: