Added auto reconnect and no team state flags #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was fixed in Mar 31 ish as can be seen here slackapi/python-slack-sdk#118 |
|
Didn't realise there was good shit in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slack client library we're using provides auto-reconnect logic for us that we weren't using. This PR adds that logic through setting the
auto_reconnectflag and also sets thewith_team_stateflag toFalsefor a lighter connection (which is recommended for larger teams such as ours)See: https://slackapi.github.io/python-slackclient/real_time_messaging.html#rtm-start-vs-rtm-connect