-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(4as): exposure assessment sidebar expand and check at the same time #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bon-carpo
approved these changes
Jan 31, 2024
bon-carpo
changed the title
WIP(4as): exposure assessment sidebar expand and check at the same time
fix(4as): exposure assessment sidebar expand and check at the same time
Jan 31, 2024
bon-carpo
added a commit
that referenced
this pull request
Jan 31, 2024
…#341) * update noah-playground-store to contain risk assessment state * add risk assessment group component * delete laguna solo component * update service to accommodate risk assessment setters and getters * add risk assessment solo component * display risk assessment in studio * add risk assessment modal component * add content for risk assessment modal * expand risk assessment component * add service for risk assessment and rename modal service * feat(4as-modal): popup modal when calculate risk button is clicked (#340) * feat(4as): add data in modal risk assessment (#342) * add risk assessment service * display data in risk modal * change table layout * add x button to close modal * update modal service * feat(4as): display population affected in map and list of affected population in modal (#346) * Cannot click button calculate risk if either rain or population is not selected * button for hide modal * hide modal and show the risk assessment button * modal close button also remove risk assessment button hide button to show risk assessment button * hide button risk assessment when uncheck the risk assessment sidebar * added data for affected population * add search for affected population * add sort in risk assessment * data summary modal ui --------- Co-authored-by: kennethliporada <62271587+kennethliporada@users.noreply.github.com> * change to list of province * feat(4as): 4as modal, affected population display, legend and pagination (#347) * putting comma for 4as data summaryt * hide/show affected population and hide data summary button * close modal and hide affected population as well * added svg to close and minimize button * adjust font text for modal header * table header display when scrolling down * example data for the 4as modal table * affected population data with psgc * added legend for rainforcast and exposure * remove console log * edited legend for rain forecast and exposure population * exposure population legend * added a value for affected population VAR 1 * displaying data from ngrok and pagination * display number data in pagination * all search for the data * toggle legend for exposure population * changing legend Risk to Population * added rainforcast with function in checkbox toggle * rain forecast legend text bigger * population exposure legend title edited * pagination for modal data summary 4as * changing url for rain forecast * Calculate risk font size bigger * no data available in table font bigger * for presentation: disclaimer not for prod, problem: mobile view UI * no available affected data when there is no affected * fix pagination button and size of the table * inserted beta to the risk assessment sidebar * remove Data summary button and replace it to the map component * replace 4as data summary button to the map component * remain checked when sidebar is toggle * created a function to stay checked the checkbox population * added a boolean shown to population checkbox * fix bug about the checkbox population * added a function for the calculate risk button * fix bug for the checkboxes * opacity for the rainforecast * added a opacity to the population affected * remove the word available and border on summary * remove the word available and border on summary (#349) * changing color blink on beta * changed based url * adjust text in ra summary dashboard * fix(4as): Change UI/UX of 4As feature and summary dashboard (#350) * sir mahar changes * checkbox Rain = true to perform the enabled and disabled button * change opacity * disclaimer in the bottom * fix expanded feature for exposure assessment * exposure assessment sidebar expand and check at the same time (#351) --------- Co-authored-by: Ken <62271587+kennethliporada@users.noreply.github.com>
bon-carpo
added a commit
that referenced
this pull request
Feb 1, 2024
…dio (#337) * remove 24hour lapse contour * feat(4as): create base component for risk/exposure assessment feature (#341) * update noah-playground-store to contain risk assessment state * add risk assessment group component * delete laguna solo component * update service to accommodate risk assessment setters and getters * add risk assessment solo component * display risk assessment in studio * add risk assessment modal component * add content for risk assessment modal * expand risk assessment component * add service for risk assessment and rename modal service * feat(4as-modal): popup modal when calculate risk button is clicked (#340) * feat(4as): add data in modal risk assessment (#342) * add risk assessment service * display data in risk modal * change table layout * add x button to close modal * update modal service * feat(4as): display population affected in map and list of affected population in modal (#346) * Cannot click button calculate risk if either rain or population is not selected * button for hide modal * hide modal and show the risk assessment button * modal close button also remove risk assessment button hide button to show risk assessment button * hide button risk assessment when uncheck the risk assessment sidebar * added data for affected population * add search for affected population * add sort in risk assessment * data summary modal ui --------- Co-authored-by: kennethliporada <62271587+kennethliporada@users.noreply.github.com> * change to list of province * feat(4as): 4as modal, affected population display, legend and pagination (#347) * putting comma for 4as data summaryt * hide/show affected population and hide data summary button * close modal and hide affected population as well * added svg to close and minimize button * adjust font text for modal header * table header display when scrolling down * example data for the 4as modal table * affected population data with psgc * added legend for rainforcast and exposure * remove console log * edited legend for rain forecast and exposure population * exposure population legend * added a value for affected population VAR 1 * displaying data from ngrok and pagination * display number data in pagination * all search for the data * toggle legend for exposure population * changing legend Risk to Population * added rainforcast with function in checkbox toggle * rain forecast legend text bigger * population exposure legend title edited * pagination for modal data summary 4as * changing url for rain forecast * Calculate risk font size bigger * no data available in table font bigger * for presentation: disclaimer not for prod, problem: mobile view UI * no available affected data when there is no affected * fix pagination button and size of the table * inserted beta to the risk assessment sidebar * remove Data summary button and replace it to the map component * replace 4as data summary button to the map component * remain checked when sidebar is toggle * created a function to stay checked the checkbox population * added a boolean shown to population checkbox * fix bug about the checkbox population * added a function for the calculate risk button * fix bug for the checkboxes * opacity for the rainforecast * added a opacity to the population affected * remove the word available and border on summary * remove the word available and border on summary (#349) * changing color blink on beta * changed based url * adjust text in ra summary dashboard * fix(4as): Change UI/UX of 4As feature and summary dashboard (#350) * sir mahar changes * checkbox Rain = true to perform the enabled and disabled button * change opacity * disclaimer in the bottom * fix expanded feature for exposure assessment * exposure assessment sidebar expand and check at the same time (#351) --------- Co-authored-by: Ken <62271587+kennethliporada@users.noreply.github.com> * feat(4as): disclaimer IoT and 4as responsive, also the bug when search (#352) * IoT logo in disclaimer resize in mobile view * disclaimer for 4as * bug when search location and then no data appear * fixed bug when search not in the list and became no data * fix(4as): change legend for rain forecast and population and adjust whitespace in mobile view (#353) * legend for rain and population * adjust white space in menu bottom mobile view * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Ken <62271587+kennethliporada@users.noreply.github.com>
bon-carpo
added a commit
that referenced
this pull request
Feb 8, 2024
… UI (#354) * remove 24hour lapse contour * feat(4as): create base component for risk/exposure assessment feature (#341) * update noah-playground-store to contain risk assessment state * add risk assessment group component * delete laguna solo component * update service to accommodate risk assessment setters and getters * add risk assessment solo component * display risk assessment in studio * add risk assessment modal component * add content for risk assessment modal * expand risk assessment component * add service for risk assessment and rename modal service * feat(4as-modal): popup modal when calculate risk button is clicked (#340) * feat(4as): add data in modal risk assessment (#342) * add risk assessment service * display data in risk modal * change table layout * add x button to close modal * update modal service * feat(4as): display population affected in map and list of affected population in modal (#346) * Cannot click button calculate risk if either rain or population is not selected * button for hide modal * hide modal and show the risk assessment button * modal close button also remove risk assessment button hide button to show risk assessment button * hide button risk assessment when uncheck the risk assessment sidebar * added data for affected population * add search for affected population * add sort in risk assessment * data summary modal ui --------- Co-authored-by: kennethliporada <62271587+kennethliporada@users.noreply.github.com> * change to list of province * feat(4as): 4as modal, affected population display, legend and pagination (#347) * putting comma for 4as data summaryt * hide/show affected population and hide data summary button * close modal and hide affected population as well * added svg to close and minimize button * adjust font text for modal header * table header display when scrolling down * example data for the 4as modal table * affected population data with psgc * added legend for rainforcast and exposure * remove console log * edited legend for rain forecast and exposure population * exposure population legend * added a value for affected population VAR 1 * displaying data from ngrok and pagination * display number data in pagination * all search for the data * toggle legend for exposure population * changing legend Risk to Population * added rainforcast with function in checkbox toggle * rain forecast legend text bigger * population exposure legend title edited * pagination for modal data summary 4as * changing url for rain forecast * Calculate risk font size bigger * no data available in table font bigger * for presentation: disclaimer not for prod, problem: mobile view UI * no available affected data when there is no affected * fix pagination button and size of the table * inserted beta to the risk assessment sidebar * remove Data summary button and replace it to the map component * replace 4as data summary button to the map component * remain checked when sidebar is toggle * created a function to stay checked the checkbox population * added a boolean shown to population checkbox * fix bug about the checkbox population * added a function for the calculate risk button * fix bug for the checkboxes * opacity for the rainforecast * added a opacity to the population affected * remove the word available and border on summary * remove the word available and border on summary (#349) * changing color blink on beta * changed based url * adjust text in ra summary dashboard * fix(4as): Change UI/UX of 4As feature and summary dashboard (#350) * sir mahar changes * checkbox Rain = true to perform the enabled and disabled button * change opacity * disclaimer in the bottom * fix expanded feature for exposure assessment * exposure assessment sidebar expand and check at the same time (#351) --------- Co-authored-by: Ken <62271587+kennethliporada@users.noreply.github.com> * feat(4as): disclaimer IoT and 4as responsive, also the bug when search (#352) * IoT logo in disclaimer resize in mobile view * disclaimer for 4as * bug when search location and then no data appear * fixed bug when search not in the list and became no data * fix(4as): change legend for rain forecast and population and adjust whitespace in mobile view (#353) * legend for rain and population * adjust white space in menu bottom mobile view * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * align logos and paraphrase the text content and insert disclaimer * added a date text in 4as summary modal * when no search display search and when no data display no forecast * download archive data * edited logos * edited some dropdown and services * fix alert text * clean code for noah playground * deleted some text issue * edit class text --------- Co-authored-by: bon-carpo <jccarpo@up.edu.ph> Co-authored-by: bon-carpo <76890692+bon-carpo@users.noreply.github.com> Co-authored-by: upri <upri@Bon-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loom
https://www.loom.com/share/de95ac9664234440a6d76f1161dd8f3c?sid=ac6933a0-5d42-41f2-88f7-084dfc3c0c24