feat: optimize dockerfiles #226
Draft
+113
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason the initial NextJS request to get the current canvas info fails and I'm not sure why. I don't know if its because of my changes (presumably it is) or whether it just doesn't work locally in a dockerfile because I can't run the original ones 😓 |
jaskfla
reviewed
May 11, 2024
Comment on lines
+7
to
+9
| # Disable Husky hooks https://typicode.github.io/husky/how-to.html#ci-server-and-docker | ||
| ENV HUSKY=0 | ||
| ENV PACKAGE_PATH=packages/backend |
There was a problem hiding this comment.
Currently looks like PACKAGE_PATH is part of disabling Husky
Suggested change
| # Disable Husky hooks https://typicode.github.io/husky/how-to.html#ci-server-and-docker | |
| ENV HUSKY=0 | |
| ENV PACKAGE_PATH=packages/backend | |
| # Disable Husky hooks https://typicode.github.io/husky/how-to.html#ci-server-and-docker | |
| ENV HUSKY=0 | |
| ENV PACKAGE_PATH=packages/backend |
Comment on lines
+7
to
+9
| # Disable Husky hooks https://typicode.github.io/husky/how-to.html#ci-server-and-docker | ||
| ENV HUSKY=0 | ||
| ENV PACKAGE_PATH=packages/frontend |
There was a problem hiding this comment.
Suggested change
| # Disable Husky hooks https://typicode.github.io/husky/how-to.html#ci-server-and-docker | |
| ENV HUSKY=0 | |
| ENV PACKAGE_PATH=packages/frontend | |
| # Disable Husky hooks https://typicode.github.io/husky/how-to.html#ci-server-and-docker | |
| ENV HUSKY=0 | |
| ENV PACKAGE_PATH=packages/frontend |
Comment on lines
+29
to
+31
| ENV HUSKY=0 | ||
| ENV NODE_ENV=production | ||
| ENV PACKAGE_PATH=packages/frontend |
There was a problem hiding this comment.
Lines 29 and 31 are already set above, and NODE_ENV should be automatically set by NextJS
Comment on lines
+33
to
+34
| # Uncomment the following line in case you want to disable telemetry during runtime. | ||
| ENV NEXT_TELEMETRY_DISABLED 1 |
There was a problem hiding this comment.
You have uncommented it 🧐
Suggested change
| # Uncomment the following line in case you want to disable telemetry during runtime. | |
| ENV NEXT_TELEMETRY_DISABLED 1 | |
| ENV NEXT_TELEMETRY_DISABLED 1 |
| @@ -30,7 +30,7 @@ | |||
| "format:fix": "pnpm --recursive format:fix", | |||
| "check": "pnpm --recursive check", | |||
| "check:fix": "pnpm --recursive check:fix", | |||
| "prepare": "husky", | |||
| "prepare": "husky || true", | |||
Comment on lines
+1
to
+9
| const path = require("node:path"); | ||
|
|
||
| module.exports = { | ||
| output: "standalone", | ||
| experimental: { | ||
| // this includes files from the monorepo base two directories up | ||
| outputFileTracingRoot: path.join(__dirname, "../.."), | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const path = require("node:path"); | |
| module.exports = { | |
| output: "standalone", | |
| experimental: { | |
| // this includes files from the monorepo base two directories up | |
| outputFileTracingRoot: path.join(__dirname, "../.."), | |
| }, | |
| }; | |
| const path = require("node:path"); | |
| const monorepoRoot = "../.." | |
| module.exports = { | |
| output: "standalone", | |
| experimental: { | |
| outputFileTracingRoot: path.join(__dirname, monorepoRoot), | |
| }, | |
| }; |
Relatedly, would path.resolve() be better here?
|
It could be nice to put the deployment scripts into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues building the original docker files. These also only include what's necessary so the images are MUCH smaller: ~1.6GB to 160 MB.